-
Notifications
You must be signed in to change notification settings - Fork 830
Update sidebar label for "reading user data" guide + linked in Declarative mode react router guide #2678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I'd say we can rename all the pages to "Protect content and read user data". "Read" instead of "access" just because the URL is /reading so lets keep read in the title somehow. Plus if you think about CRUD, users should be familiar with what Read means.
for each guide, lets have the metadata title "Read session and user data in your app with Clerk"
metadata titles can be set in the frontmatter with the metadata property
let me know what you think about this direction👂
Here are the changes: Changes post feedback |
🔎 Previews:
What does this solve?
This PR follows user feedback regarding being confused on how to setup different routes for public and private content in a React Router app, after being in the Declarative mode guide. The solution was to change the sidebar name from Reading user data to Protect content and access user data, to make it more clear to users what type of guide it is. We also wanted to link that guide at the end of the Declarative mode guide as a next step.
What changed?
Important note: Noticed that for other SDKs, the title remains "Read session and user data in your X app with Clerk" (for e.g., Next.js, Tanstack etc). See screenshot below. Do we want to change the titles of those too to be in accordance with the sidebar title?
Checklist